Conversation
|
This relates to RPOPC-880 |
grdumas
added
documentation
grdumas
requested changes
Mar 25, 2026
Contributor
grdumas
left a comment
grdumas
left a comment
There was a problem hiding this comment.
Based on the order of code execution exit_out() is undefined and will lead to unintended behavior.
Code redundancy could be reduced by refactoring attempt_tools_wget and attempt_tools_curl but not a breaker.
grdumas
requested changes
Mar 26, 2026
Contributor
grdumas
left a comment
grdumas
left a comment
There was a problem hiding this comment.
The exit command does not appear to be working correctly, see comment.
grdumas
requested changes
Mar 26, 2026
grdumas
added
the
group_review_lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update how we are pulling test_tools
Before/After Comparison
Before: We only used git, if git was not present, we would fail.
After: We now try git, curl and wget.
Clerical Stuff
This closes #62
Mention the JIRA ticket of the issue, this helps keep
everything together so we can find this PR easily.
Relates to JIRA: RPOPC-880
Testing done
Ran the following scenario file
global:
ssh_key_file: replace_your_ssh_key
terminate_cloud: 1
os_vendor: rhel
results_prefix: streams_res
os_vendor: rhel
system_type: aws
cloud_os_id: ami-035032ea878eca201
systems:
system1:
tests: "streams"
host_config: "m5.xlarge"
csv file generated
Array_sizes,36608k,73216k,146432k,292864k,Start_Date,End_Date
Copy,8687,9375,9745,10197,2026-03-14T14:54:55Z,2026-03-14T15:10:51Z
Scale,9728,10054,11000,11448,2026-03-14T14:54:55Z,2026-03-14T15:10:51Z
Add,10738,10902,11986,11962,2026-03-14T14:54:55Z,2026-03-14T15:10:51Z
Triad,10689,11284,11996,12009,2026-03-14T14:54:55Z,2026-03-14T15:10:51Z