Skip to content

Remove unused install_resource_time_output to fix GHA secret warning#1201

Merged
ebattat merged 3 commits intomainfrom
remove-unused-install-resource-time-output
Apr 24, 2026
Merged

Remove unused install_resource_time_output to fix GHA secret warning#1201
ebattat merged 3 commits intomainfrom
remove-unused-install-resource-time-output

Conversation

@ebattat
Copy link
Copy Markdown
Member

@ebattat ebattat commented Apr 23, 2026

The output was defined but never consumed by any downstream job, causing "Skip output since it may contain secret" warnings.

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

This PR should fix the following annotation warnings: https://github.com/redhat-performance/benchmark-runner/actions/runs/24820227273

For security reasons, all pull requests need to be approved first before running any automated CI

The output was defined but never consumed by any downstream job,
causing "Skip output since it may contain secret" warnings.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested a review from RobertKrawitz April 23, 2026 08:09
@ebattat ebattat requested a review from arpsharm April 23, 2026 08:09
@ebattat ebattat self-assigned this Apr 23, 2026
@github-project-automation github-project-automation Bot moved this to In progress in benchmark-runner Apr 23, 2026
ebattat and others added 2 commits April 23, 2026 12:29
Replace deprecated mock_s3 decorator with mock_aws and remove the
warnings suppression workaround that was no longer effective at runtime.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Member

@arpsharm arpsharm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arpsharm, ebattat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebattat ebattat merged commit 9ae8543 into main Apr 24, 2026
6 of 7 checks passed
@ebattat ebattat deleted the remove-unused-install-resource-time-output branch April 24, 2026 10:20
@github-project-automation github-project-automation Bot moved this from In progress to Done in benchmark-runner Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants