OCPBUGS-109639: Backport e1 default value - #741
Conversation
Prefer the T-BC stats key for T-BC profiles and treat unset E1 as FREERUN so a lone phc2sys LOCKED sample cannot make OS-clock E3 LOCKED too early after CEP restart or profile apply. Generated-by: Cursor
Use GetProfileTypeByConfigName when selecting the E1 key, harden the missing-E1 FREERUN test for cached NONE ProfileType, and clear goconst literals in T-BC tests. Generated-by: Cursor
Table-drive missing-E1 FREERUN cases, cover RefreshProfileTypes and IsTBCProfile, and assert non-T-BC profiles still use master for E3. Generated-by: Cursor
Packages sharing STORE_PATH and fixed API ports raced on pub.json and CreatePublisher during parallel package runs. Generated-by: Cursor
os.Exit skips deferred cleanup, so run cleanUP and RemoveAll before exiting while keeping defers for panic paths. Generated-by: Cursor
OC/BC set E1 from ptp4l, so leave unset E1 alone and only force FREERUN for profiles that rely on delayed X-STATUS. Also hold the profile-type lookup lock for the full GetProfileTypeByConfigName call. Generated-by: Cursor
|
@nocturnalastro: This pull request references Jira Issue OCPBUGS-109639, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nocturnalastro The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
No description provided.