CNF-26637: Deprecate minOffsetThreshold and use absolute offset comparison

[vitus133]

Summary

In ptpClockThreshold, threshold configuration currently specifies both maxOffsetThreshold and minOffsetThreshold. Because timing offsets are symmetric, defining separate upper and lower offset boundaries is redundant.

minOffsetThreshold is deprecated in favor of a single absolute-value comparison against maxOffsetThreshold:

abs(offset) < maxOffsetThreshold

This PR updates isOffsetInRange() and its call sites in cloud-event-proxy to evaluate whether abs(offset) < maxOffsetThreshold (non-inclusive boundary, preserving existing comparison semantics).

Jira

• https://redhat.atlassian.net/browse/CNF-26630
• Parent: CNF-25637

Testing

• Unit tests added in logparser_internal_test.go and config_test.go covering in-range, out-of-range positive/negative, exact non-inclusive boundary, and backward compatibility when minOffsetThreshold is omitted/zero/asymmetric.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e074e73-2faa-47ae-9d48-c50449533985

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@vitus133: This pull request references CNF-26637 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

In ptpClockThreshold, threshold configuration currently specifies both maxOffsetThreshold and minOffsetThreshold. Because timing offsets are symmetric, defining separate upper and lower offset boundaries is redundant.

minOffsetThreshold is deprecated in favor of a single absolute-value comparison against maxOffsetThreshold:

abs(offset) < maxOffsetThreshold

This PR updates isOffsetInRange() and its call sites in cloud-event-proxy to evaluate whether abs(offset) < maxOffsetThreshold (non-inclusive boundary, preserving existing comparison semantics).

Jira

• https://redhat.atlassian.net/browse/CNF-26630
• Parent: CNF-25637

Testing

• Unit tests added in logparser_internal_test.go and config_test.go covering in-range, out-of-range positive/negative, exact non-inclusive boundary, and backward compatibility when minOffsetThreshold is omitted/zero/asymmetric.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vitus133]

/verified later @dpopsuev

[openshift-ci-robot]

@vitus133: This PR has been marked to be verified later by @dpopsuev.

Details

In response to this:

/verified later @dpopsuev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[nocturnalastro]

/lgtm

[nocturnalastro]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nocturnalastro, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [nocturnalastro,vitus133]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vitus133]

/verified later @dpopsuev

[openshift-ci-robot]

@vitus133: This PR has been marked to be verified later by @dpopsuev.

Details

In response to this:

/verified later @dpopsuev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.