Repository navigation
[phpunit] WithConsecutiveRector should be removed from PHPUnitSetList::PHPUNIT_90 #9366
Description
Processing file with this rule ends up in the not valid code (at least on PHPUnit v 9.6.23)
Sample change
1) tests/SampleTest.php:79
---------- begin diff ----------
@@ @@
$eventDispatcher = $this->getMockBuilder(EventDispatcherInterface::class)
->disableOriginalConstructor()
->onlyMethods(['dispatch'])
->getMock()
;
+ /* @phpstan-ignore-next-line method.deprecated (no alternative?) */
+ $matcher = self::exactly(2);
/* @phpstan-ignore-next-line method.deprecated (no alternative?) */
- $eventDispatcher->expects(self::exactly(2))
- ->method('dispatch')
- ->withConsecutive(
- [self::isInstanceOf(SubscribedEvent::class)],
- [self::isInstanceOf(UnsubscribedEvent::class)]
- )
+ $eventDispatcher->expects($matcher)
+ ->method('dispatch')->willReturnCallback(function (...$parameters) use ($matcher): void {
+ if ($matcher->numberOfInvocations() === 1) {
+ $this->assertSame(self::isInstanceOf(SubscribedEvent::class), $parameters[0]);
+ }
+ if ($matcher->numberOfInvocations() === 2) {
+ $this->assertSame(self::isInstanceOf(UnsubscribedEvent::class), $parameters[0]);
+ }
+ })
Error: Call to undefined method PHPUnit\Framework\MockObject\Rule\InvokedCount::numberOfInvocations()
Metadata
Metadata
Assignees
Labels
No labels
Activity
TomasVotruba commentedon Sep 7, 2025
This method was deprecated in PHPUnit 9 and removed in 10, so set is correct.
The rule should check for correct new method name instead and apply existing one based on real project code.
dczech commentedon Sep 7, 2025
The project is based on Symfony 6.4 + symfony/phpunit-bridge and installs PHPUnit through bin/phpunit helper script. This is probably the reason why rector assumes PHPUnit 10 is available.
TomasVotruba commentedon Sep 7, 2025
With reflection check, the version doesn't really matter. The first existing method should be used.
Btw, PHPUnit bridge is pretty messy package, that should be used only in
symfony/symfonymonorepo to allow running many PHPUnit versions. Removed anywhere else. Unfortunatelly, legacy Symfony skeletons spread it in many projects by default with no gain.[-]WithConsecutiveRector should be removed from PHPUnitSetList::PHPUNIT_90[/-][+][phpunit] WithConsecutiveRector should be removed from PHPUnitSetList::PHPUNIT_90[/+]TomasVotruba commentedon Sep 10, 2025
Resolved in rectorphp/rector-phpunit#546
github-actions commentedon Feb 8, 2026
This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.