Repository navigation
[symfony 8.2] Add Symfony 8.2 rules: Schedule::with() to add() and Doctrine middleware renames - #1082
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds first rules targeting Symfony 8.2 deprecations.
ScheduleWithToAddRector
Schedule::with()is deprecated in 8.2. Internally it always diddoAdd(new self(), ...), i.e. derived from a fresh emptySchedule, so the exact replacement is(new Schedule())->add(...)(notclone, which would keep the receiver's messages).Gated on
symfony/scheduler >=8.2. Stubs added since the package is not installed.Doctrine middleware renames (RenameClassRector)
Added to
composer-based.php, gated onsymfony/doctrine-bridge >=8.2:DoctrineCloseConnectionMiddleware->DoctrineDbalCloseConnectionMiddlewareDoctrinePingConnectionMiddleware->DoctrineDbalPingConnectionMiddlewareConstructors are type-compatible (
ManagerRegistryextendsConnectionRegistry, second arg stays string-compatible), so a plain class rename is safe.DoctrineOpenTransactionLoggerMiddlewareis intentionally not renamed: its constructor argument order changed (logger moves to 2nd position), so a bare class rename would produce broken instantiations.Ref: https://github.com/symfony/symfony/blob/8.2/UPGRADE-8.2.md
Note: Symfony 8.2 is not released yet, so the API may still change.