Operator and testing modernization for cache .Filter() operators, as described in #1014.#1048
Open
JakenVeina wants to merge 1 commit intomainfrom
Open
Operator and testing modernization for cache .Filter() operators, as described in #1014.#1048JakenVeina wants to merge 1 commit intomainfrom
.Filter() operators, as described in #1014.#1048JakenVeina wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
@JakenVeina there's some conflicts to resolve here |
JakenVeina
force-pushed
the
housekeeping/cache-filter-modernization
branch
3 times, most recently
from
0869c11 to
3d179a6
Compare
…s described in #1014. Includes full re-write of the static version of `.Filter()`, to promote consistent organization among all filtering operators, and to fix a missing null parameter check. Includes refactoring and enhancement to combine the two separate backing classes for `.Filter()` operators into one, by adding `reapplyFilter` support to the newer one. Includes full rewrite of the cache .Filter() testing suite.
JakenVeina
force-pushed
the
housekeeping/cache-filter-modernization
branch
from
3d179a6 to
49cdb2e
Compare
Collaborator
Author
|
Only took me accidentally orphaning the commit and having to recover it from the reflog, but should be good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes full re-write of the static version of
.Filter(), to promote consistent organization among all filtering operators, and to fix a missing null parameter check.Includes refactoring and enhancement to combine the two separate backing classes for
.Filter()operators into one, by addingreapplyFiltersupport to the newer one.Includes full rewrite of the cache .Filter() testing suite.