Skip to content

Refresh DeviceInfo constants on each read (#57715) - #57715

Closed
cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D113758830
Closed

cipolleschi wants to merge 1 commit into
react:mainfrom
cipolleschi:export-D113758830

Conversation

@cipolleschi

@cipolleschi cipolleschi commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Update NativeDeviceInfo.getConstants() to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh DeviceInfo constants on each read

Test Plan:

  • yarn build-types --validate
  • arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts
  • Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2026
@meta-codesync

meta-codesync Bot commented Jul 28, 2026

Copy link
Copy Markdown

@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113758830.

@github-actions

Copy link
Copy Markdown

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: POTENTIALLY_BREAKING

cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Jul 28, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
@meta-codesync meta-codesync Bot changed the title Refresh DeviceInfo constants on each read Refresh DeviceInfo constants on each read (#57715) Jul 28, 2026
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Jul 28, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Jul 28, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 10, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 10, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 10, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 10, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 10, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 10, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 11, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 11, 2026
Summary:
Pull Request resolved: react#57715

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Aug 25, 2026
Summary:

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
Summary:

Update `NativeDeviceInfo.getConstants()` to read directly from the native module instead of retaining a stale JS-side cache.

Changelog:
[General][Fixed] - Refresh `DeviceInfo` constants on each read

Test Plan:
- `yarn build-types --validate`
- `arc lint xplat/js/react-native-github/packages/react-native/ReactNativeApi.d.ts`
- Verify Dimensions updates after resizing the RNTester window.

Reviewed By: javache

Differential Revision: D113758830

Pulled By: cipolleschi
@meta-codesync meta-codesync Bot closed this in 9d10e39 Aug 25, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Aug 25, 2026
@meta-codesync

meta-codesync Bot commented Aug 25, 2026

Copy link
Copy Markdown

@cipolleschi merged this pull request in 9d10e39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants