fix: support bounds='parent' for SVG elements and flexbox layouts #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use getBoundingClientRect() as fallback for SVG elements which lack clientWidth/clientHeight properties - Calculate SVG element offsets using bounding rectangles since they don't have offsetLeft/offsetTop - Accept Element (not just HTMLElement) for bounds container to support SVG parent elements - HTMLElements still use the fast path (clientWidth/clientHeight) Fixes #213 Closes #594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getBoundingClientRect()as fallback for SVG elements which lackclientWidth/clientHeightpropertiesoffsetLeft/offsetTopElement(not justHTMLElement) for bounds container to support SVG parent elementsclientWidth/clientHeight)coverage/to.gitignoreFixes #213
Closes #594
Test plan