fix(types): remove global module declaration to prevent type pollution #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STRML
force-pushed
the
fix/typescript-module-690
branch
from
f30c488 to
07c6864
Compare
Removes the `declare module 'react-draggable'` wrapper from TypeScript definitions and uses direct exports instead. This fixes type pollution issues when multiple versions of react-draggable end up in a project's dependencies. The global module declaration is unnecessary as TypeScript will automatically associate the typings with the `react-draggable` module since they're declared in package.json. Closes #690
STRML
force-pushed
the
fix/typescript-module-690
branch
from
07c6864 to
08e265e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
declare module 'react-draggable'wrapper from TypeScript definitions and uses direct exports instead. This fixes type pollution issues when multiple versions of react-draggable end up in a project's dependencies.This is a fresh implementation of the fix proposed in #690.
Changes
declare module 'react-draggable'wrapper fromtypings/index.d.tstypings/tsconfig.jsonto use path mapping for the test fileWhy this works
The global module declaration is unnecessary as TypeScript will automatically associate the typings with the
react-draggablemodule since they're declared in package.json. The previous approach caused type pollution in complex dependency scenarios.See reproduction repo: https://github.com/pgoldberg/react-draggable-typings-bug
Test plan