Skip to content

fix(locale): use Taiwan week terminology - #1007

Open
nrps9909 wants to merge 1 commit into
react-component:masterfrom
nrps9909:codex/fix-zhtw-week-term
Open

fix(locale): use Taiwan week terminology#1007
nrps9909 wants to merge 1 commit into
react-component:masterfrom
nrps9909:codex/fix-zhtw-week-term

Conversation

@nrps9909

@nrps9909 nrps9909 commented Aug 27, 2026

Copy link
Copy Markdown

Summary

  • replace the Mainland Chinese week character in the Traditional Chinese week-selection prompt
  • keep weekSelect consistent with the existing week: 週 label
  • add a focused locale regression

The zh_TW locale currently mixes 選擇周 with in the same object. Taiwan usage consistently uses , so the picker prompt should read 選擇週.

Verification

  • Exact-base causal check: the new locale regression was the only failing assertion with weekSelect: 選擇周
  • Fixed full suite: 16 suites passed, 469 tests passed, 2 skipped, 29 snapshots passed
  • npm run tsc
  • npm run lint — 0 errors, 16 pre-existing hook warnings
  • npm run compile — ESM, CJS, declarations, and CSS passed
  • prettier --check src/locale/zh_TW.ts tests/locale-zh-tw.spec.ts
  • git diff --check

I checked every current open PR and its changed files before implementation. #987 also adds independent time-panel labels to zh_TW.ts, but it does not modify weekSelect; this patch is semantically separate, with only a possible trivial same-file rebase overlap.

AI assistance disclosure: Codex was used to audit locale consistency and open-PR overlap, add the regression, and run verification. I reviewed the wording, causal failure, and final diff before submission.

Summary by CodeRabbit

  • 文案更新

    • 修正繁体中文界面中的“选择周”文案为“選擇週”,用字更加准确。
  • 测试

    • 新增验证,确保该文案持续使用正确的繁体字。

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@nrps9909 is attempting to deploy a commit to the afc163's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2bd449e6-56d8-48c5-8822-d8071fde1845

📥 Commits

Reviewing files that changed from the base of the PR and between 16084b6 and 76e6f35.

📒 Files selected for processing (2)
  • src/locale/zh_TW.ts
  • tests/locale-zh-tw.spec.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

zh_TW locale 的 weekSelect 文案改为「選擇週」。新增测试验证完整文案及「週」字元。

Changes

zh_TW locale 文案更新

Layer / File(s) Summary
更新 weekSelect 文案并验证
src/locale/zh_TW.ts, tests/locale-zh-tw.spec.ts
weekSelect 从「選擇周」改为「選擇週」。测试断言完整文案和「週」字元。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 76e6f

This localized Traditional Chinese wording change updates the week-selection prompt to use Taiwan’s existing terminology and adds regression coverage; no actionable merge-blocking risk remains after normal checks and review.

Poem

小兔改好「週」字文案
测试轻敲确认无差
旧字告别新字到
locale 继续稳稳跑
胡萝卜旁写下赞歌

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了主要变更:将 zh_TW locale 的周选择术语调整为符合台湾用语的表达。标题简洁、明确,并与新增回归测试一致。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant