fix(locale): use Taiwan week terminology - #1007
Conversation
|
@nrps9909 is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. Walkthrough
Changeszh_TW locale 文案更新
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized Traditional Chinese wording change updates the week-selection prompt to use Taiwan’s existing Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
weekSelectconsistent with the existingweek: 週labelThe
zh_TWlocale currently mixes選擇周with週in the same object. Taiwan usage consistently uses週, so the picker prompt should read選擇週.Verification
weekSelect: 選擇周npm run tscnpm run lint— 0 errors, 16 pre-existing hook warningsnpm run compile— ESM, CJS, declarations, and CSS passedprettier --check src/locale/zh_TW.ts tests/locale-zh-tw.spec.tsgit diff --checkI checked every current open PR and its changed files before implementation. #987 also adds independent time-panel labels to
zh_TW.ts, but it does not modifyweekSelect; this patch is semantically separate, with only a possible trivial same-file rebase overlap.AI assistance disclosure: Codex was used to audit locale consistency and open-PR overlap, add the regression, and run verification. I reviewed the wording, causal failure, and final diff before submission.
Summary by CodeRabbit
文案更新
测试