fix(locale): refine Traditional Chinese page-size terms - #719
Conversation
Use Taiwan-appropriate record terminology for the visible size options and replace the misleading page-number label on the page-size combobox. AI-assisted: Codex Signed-off-by: 陳廷安 <73953029+nrps9909@users.noreply.github.com>
|
@nrps9909 is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Walkthrough更新繁体中文分页本地化文本,并新增测试验证每页笔数标签和选项文本。 Changes繁体中文分页本地化
Estimated code review effort: 1 (简单) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized copy correction is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: private package registry requires authentication. Disable ESLint in CodeRabbit settings or use public packages. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #719 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 4 4
Lines 331 331
Branches 152 152
=======================================
Hits 330 330
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
條/頁with the Taiwan-standard筆/頁頁碼(page number) with每頁筆數(items per page)Why
page_sizeis passed to the size changer as itsaria-label, so頁碼describes the wrong control. This package is the canonical Pagination locale used by Ant Design; correcting the source keeps both the rendered copy and assistive-technology output accurate for zh-TW users.Validation
npm test -- tests/options.test.tsx --runInBand(3 tests, 1 snapshot)npm test -- --runInBand(10 suites, 222 tests, 130 snapshots)npm run lintnpm run tscnpm run compilenpx prettier --check src/locale/zh_TW.ts tests/options.test.tsxgit diff --checkAI assistance disclosure: Codex was used to trace the locale value to the rendered size changer, draft the focused patch and regression test, audit open pull requests for overlap, and run the validation commands above.
Summary by CodeRabbit
本地化
测试