Repository navigation
[ci] skip the array filter check on non-PR builds - #512
Open
elliot-barn wants to merge 1 commit into
Open
elliot-barn wants to merge 1 commit into
elliot-barn wants to merge 1 commit into
Conversation
Non-PR builds run all tags, so every array-step variant runs on main and the four variants the check rejects fail on every main build. The check only means something on a filtered PR build, so exit 0 when BUILDKITE_PULL_REQUEST is false. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Elliot Barnwell <elliot.barnwell@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Buildkite configuration in .buildkite/array-test.rayci.yaml to skip the OS filtering check for non-pull request builds by checking the BUILDKITE_PULL_REQUEST environment variable. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Array linux-2,Array windows-1,Array windows-2andArray macos-2fail on every main build (every one back to #2446 in June, through #2481 for v0.51.0), so main is always red.The array expansion test checks that only the variants something depends on get pulled in:
Final validation(taggedalways) →Depends check only→array-step(os=linux, os=macos, variant=1). The other four variantsexit 1if they run. That only holds on a filtered PR build. On a non-PR build,needRunAllTagsselects every tag, so all six variants run and four fail by design.What
array-stepexits 0 before the filter check whenBUILDKITE_PULL_REQUESTisfalse(or unset).BUILDKITE_PULL_REQUESTis already passed into job containers (buildkiteEnvsinraycicmd/bk_pipeline.go). It is escaped as$${...}so it is read at runtime, like the other steps in this repo.PR builds keep the check: a variant that runs on a PR still fails.
Testing
Rendered the pipeline locally with the rayci pipeline config:
BUILDKITE_PULL_REQUEST=false: all 6 variants emitted (as on main today), and the command exits 0.BUILDKITE_PULL_REQUEST=4242: thewindows-2command still exits 1.BUILDKITE_PULL_REQUESTunset: exits 0.🤖 Generated with Claude Code