Move qualifier attributes from method-level to parameter-level#35
Merged
Conversation
Method-level #[CacheDir] and #[CacheNamespace] attributes on the constructor were not resolved by Ray.Di, which only processes parameter-level attributes. This caused the cache directory to always fall back to sys_get_temp_dir() instead of using the bound CacheDir value.
The bootstrap was setting up a Doctrine annotation reader via the deprecated Ray\ServiceLocator\ServiceLocator. This is no longer needed since the package uses native PHP 8 attributes. The koriym/attributes package is not declared in composer.json, causing CI to fail with "Class Koriym\Attributes\AttributeReader not found".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #35 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 38 38
===========================================
Files 24 24
Lines 90 90
===========================================
Hits 90 90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method-level #[CacheDir] and #[CacheNamespace] attributes on the constructor were not resolved by Ray.Di, which only processes parameter-level attributes. This caused the cache directory to always fall back to sys_get_temp_dir() instead of using the bound CacheDir value.