Use unsigned int instead of uint in BINARY_INFO_MAKE_TAG#3029
Merged
Conversation
lurch
reviewed
Jun 24, 2026
kilograham
previously approved these changes
Jun 29, 2026
kilograham
approved these changes
Jun 29, 2026
will-v-pi
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the BINARY_INFO_MAKE_TAG macro in the binary_info module to use
unsigned intinstead ofuint, making it more portable without users having to typedefuintthemselves, since this isn't a standard stdint type.Makes the
binary_infoheaders more portable (as intended) and is backwards compatible.Fixes #3028