Use new pio functions#766
Open
peterharperuk wants to merge 2 commits into
Open
Conversation
We twiddle input_sync_bypass directly in the pio spi example. Use the new pio_set_input_sync_bypass_with_mask64 instead. Run the loopback example at full speed and improve it so it's more obvious when the example doesn't work.
Contributor
Author
|
Depends on raspberrypi/pico-sdk#3024 |
lurch
reviewed
Jun 23, 2026
lurch
reviewed
Jun 24, 2026
| } | ||
| } | ||
| printf("Example %s\n", match_count == spi_example_runs ? "PASSED" : "FAILED"); | ||
| assert(match_count == 4); |
Contributor
There was a problem hiding this comment.
Suggested change
| assert(match_count == 4); | |
| assert(match_count == spi_example_runs); |
(Unless there's a good reason for not doing that?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We twiddle input_sync_bypass directly in the pio spi example. Use the new pio_set_input_sync_bypass_with_mask64 instead.
Run the loopback example at full speed and improve it so it's more obvious when the example doesn't work.