fix(console): remove trailing semicolons from macro expansions - #583
Open
guybedford wants to merge 1 commit into
Open
fix(console): remove trailing semicolons from macro expansions#583guybedford wants to merge 1 commit into
guybedford wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the nightly CI breakage in the Native, Browser, Node and gloo-net test jobs.
The gloo-console macros (
log!,error!,dir!, etc.) all expanded to a statement with a trailing semicolon. When such a macro is invoked in expression position (e.g. as the final expression of a block, as in the gloo-console and gloo-net crate-level doc examples), this triggers thesemicolon_in_expressions_from_macrosfuture-incompatibility lint (rust-lang/rust#79813). rust-lang/rust#159222 recently extended the lint to non-local macros at deny level, which broke the nightly doctest jobs; rust-lang/rust#159700 has since split the non-local case into a warn-level lint, but the plan remains to make this a hard error (rust-lang/rust#159218), and the lint is already deny-by-default for local macro uses on stable.())clippy::manual_filtererror in gloo-history that newer clippy flags, which was failing the Lint & Format jobMade with AI assistance under my review