Migrate soldeer dep rain-interpreter-interface 0.1.0 -> rainlang-interface 0.2.3 - #557
Closed
thedavidmeister wants to merge 3 commits into
Closed
Migrate soldeer dep rain-interpreter-interface 0.1.0 -> rainlang-interface 0.2.3#557thedavidmeister wants to merge 3 commits into
thedavidmeister wants to merge 3 commits into
Conversation
…rface 0.2.3 The interface repo/package was renamed; legacy rain-interpreter-interface is frozen at 0.1.2 and all new publishes go to rainlang-interface. - foundry.toml: rain-interpreter-interface 0.1.0 -> rainlang-interface 0.2.3 - foundry.toml: rain-math-binary 0.1.1 -> 0.1.4, because soldeer resolution is flat and rainlang-interface-0.2.3 imports rain-math-binary-0.1.4 - soldeer.lock regenerated with forge soldeer update - all import paths rewritten to the new versioned package prefixes - stale remappings for the replaced packages removed Refs rainlanguage/rainlang.interface#107 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Important Review skippedToo many files! This PR contains 253 files, which is 153 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (253)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The rainlang-interface-0.2.3 prefix is shorter than rain-interpreter-interface-0.1.0, so seven previously wrapped import blocks now fit on one line. This is the exact diff the copy-artifacts CI job produced when it ran the regen sequence (forge soldeer install, script/Build.sol, script/CopyArtifacts.sol --ffi, forge build, forge fmt) and found the working tree dirty; the regenerated pointer/meta/abi artifacts themselves were already current. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The rainix agent-context-cap check (rainlanguage/rainix#298) fails this branch's static and rs-static jobs: CLAUDE.md was 8587 bytes, 4491 over the floor-only 4096 cap. Per the check's own criterion, cut everything a capable agent can discover from the repo (command lists, architecture overview, crate layout, foundry.toml restatements) and keep what an agent would get wrong: the prelude ordering, the pointer/deploy-constant regeneration cascade, the NatSpec tagging ruling, and the jidoka process rulings. Now under 4096 bytes; verified clean with `nix run github:rainlanguage/rainix#rainix-static -- agent-context-cap .` Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #560, which carries the same interface migration at a newer version (rainlang-interface 0.2.5) plus the solmem 0.1.26 chain. Closing per the org's supersede-in-flight practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs rainlanguage/rainlang.interface#107
Migrates the soldeer dependency
rain-interpreter-interface0.1.0 torainlang-interface0.2.3. The interface repo/package was renamed; the legacyrain-interpreter-interfacepackage is frozen at 0.1.2 and all new publishes go torainlang-interface(latest 0.2.3).This delivers what #551 was blocked on:
rain-math-binary0.1.4 arrives insiderainlang-interface-0.2.3(itsLibParseMeta/LibGenParseMetaimportrain-math-binary-0.1.4/...), and because soldeer resolution is flat this repo's[dependencies]now carriesrain-math-binary = "0.1.4"to satisfy it.Changes
foundry.toml:rain-interpreter-interface = "0.1.0"->rainlang-interface = "0.2.3";rain-math-binary = "0.1.1"->"0.1.4"(required by the new package under flat resolution).soldeer.lock: regenerated withforge soldeer update.rain-interpreter-interface-0.1.0/...rewritten torainlang-interface-0.2.3/...; the one directrain-math-binary-0.1.1/src/lib/LibCtPop.solimport rewritten to0.1.4.remappings.txt: stale remappings for the two replaced package versions removed; new ones added by soldeer.Interface changes absorbed
Diffed
rain-interpreter-interface-0.1.0againstrainlang-interface-0.2.3(both from the soldeer registry): thesrc/trees are identical exceptLibParseMeta.solandLibGenParseMeta.solbumping theirLibCtPopimport fromrain-math-binary-0.1.1to-0.1.4. No API/ABI changes.rain-math-binary0.1.1 -> 0.1.4 itself is NatSpec/doc-comment-only inLibCtPop.sol— no behavioral change.Build / test
nix develop -c forge build: green.nix develop -c forge test: 1589 passed, 5 failed, 0 skipped (1594 total). The 5 failures are the pre-existingLibInterpreterDeployProd.t.soltestProdDeploy*fork tests failing on live chain state ("Interpreter not deployed"); main's own CI (run 29477065455) fails the exact same 5 tests with the same message. They assert hardcoded address/codehash constants (untouched by this diff) against live chains. Locally Polygon additionally reports HTTP 401 because the public RPC endpoint used in place of the CI secret rejects the request before the same assertion is reached.QA
LibCtPopimport bumps in src, and doc-comment-only changes inLibCtPop.solitself.🤖 Generated with Claude Code
CI fixes (post-push)
copy-artifacts(run 32215268374): the job's regen sequence (forge soldeer install,script/Build.sol,script/CopyArtifacts.sol --ffi,forge build,forge fmt) left a dirty tree —forge fmtcollapses seven import blocks that only wrapped because the oldrain-interpreter-interface-0.1.0/prefix was longer. Reproduced byte-for-byte in the same pinned rainix sol-shell and committed (4775a2c). The regenerated pointer/meta/abi artifacts themselves were already current.rainix-sol/staticandrs-static: both fail the rainixagent-context-capcheck — CLAUDE.md was 8587 bytes against the floor-only 4096 cap. Trimmed to 2086 bytes keeping repo-specific rulings, cutting discoverable content (10e0ef7); verified clean locally with the samerainix-static -- agent-context-cap .binary from rainix main.rainix-sol/test: only the 5 pre-existingtestProdDeploy*chain-state failures (1589 succeeded) — identical to main's CI. Nothing to fix on this branch.