Repository navigation
fix(etw,signature): Revive unit tests by fixing small regressions - #757
Merged
Merged
Conversation
Build both names with one helper that matches the old saferwall layout.
The memory map/unmap events are now anchored to the memory event category. Make the fs processor accept memory events too. The memory map rundown event was omitted as part of the refactoring. Bring it back.
|
| Commit: | b124b9b |
| Total: | 0 rules |
| Test scope: | Fibratus |
| Test run: | View the run |
Selection: PR changes only (matching scope patterns). No added or modified rule files match this scope's file patterns and exclusions. Deleted files are not evaluated; the full scope was not tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
The first fix addresses
pkix.Nameformatting before the PE parser rewrite. Both names (subject and issuer) are built with one helper that matches the oldsaferwalllayout.The memory map/unmap events are now anchored to the memory event category. Make the fs processor accept memory events too. The memory map rundown event was omitted as part of the refactoring. Bring it back.
What type of change does this PR introduce?
/kind bug-fix (non-breaking change which fixes an issue)
Any specific area of the project related to this PR?
/area telemetry
Special notes for the reviewer
Does this PR introduce a user-facing change?