Skip to content

fix(etw,signature): Revive unit tests by fixing small regressions - #757

Merged
rabbitstack merged 2 commits into
masterfrom
revive-unit-tests
Nov 16, 2026
Merged

rabbitstack merged 2 commits into
masterfrom
revive-unit-tests

Conversation

@rabbitstack

Copy link
Copy Markdown
Owner

What is the purpose of this PR / why it is needed?

The first fix addresses pkix.Name formatting before the PE parser rewrite. Both names (subject and issuer) are built with one helper that matches the old saferwall layout.

The memory map/unmap events are now anchored to the memory event category. Make the fs processor accept memory events too. The memory map rundown event was omitted as part of the refactoring. Bring it back.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area evasion

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


Build both names with one helper that matches the old saferwall layout.
The memory map/unmap events are now anchored to the
memory event category. Make the fs processor accept
memory events too. The memory map rundown event was
omitted as part of the refactoring. Bring it back.
@rulecheck

rulecheck Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

RuleCheck.io  RuleCheck test run results

Commit: b124b9b
Total: 0 rules
Test scope: Fibratus
Test run: View the run

Selection: PR changes only (matching scope patterns). No added or modified rule files match this scope's file patterns and exclusions. Deleted files are not evaluated; the full scope was not tested.

@rabbitstack
rabbitstack merged commit 8892982 into master Nov 16, 2026
12 of 13 checks passed
@rabbitstack
rabbitstack deleted the revive-unit-tests branch November 16, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant