Direct emissions chart and dashboard items

[kndehaan]

Context

This PR adds 1990 data to datasets, a chart and two dashboard items to the model as part of the direct emissions project.

Implemented changes

• Direct total GHG emissions chart per sector
• Dashboard items reduction in GHG emissions compared to 1990 and total future GHG emissions
• Validation of 1990 queries (ETEngine) and future emissions queries (Mechanical Turk)

Related

Goes with pull requests:

• Emissions 1990 atlas#190
• Emissions 1990 etengine#1760
• Direct emissions chart and dashboard items etsource#3449
• Direct emissions chart and dashboard items #4730
• https://github.com/quintel/etdataset/pull/1088
• Direct emissions 1990 data, chart and dashboard items mechanical_turk#219
• Documentation to be updated

Checklist

• I have tested these changes
• I have updated documentation as needed
• I have tagged the relevant people for review

[mabijkerk]

@kndehaan I think the new dashboard items should be selectable from the menu, not shown by default right? Now the bar is very cluttered:

[mabijkerk]

Might it be better to put the direct GHG chart in the "Emissions" chart selection section while it is in beta, rather than in the "Overview" section?

[mabijkerk]

Why are all the labels shown twice? Also, why is the red line shown twice in the 2050 emissions, why is it not shown for 1990?

[mabijkerk]

Ideally you would also see a column for 1990 emissions in the table view of the chart.

[mabijkerk]

I would add the new GHG chart as the default for the direct emissions download:

[kndehaan]

I think the new dashboard items should be selectable from the menu, not shown by default right? Now the bar is very cluttered

This is a caching issue (right @louispt1 ?). If you click on the dasboard items settings wheel and save again, it shows the "normal" 7 dashboard items. But it I will ask @louispt1 and @noracato again about this caching issue to ensure that this will not occur on beta or master.

Might it be better to put the direct GHG chart in the "Emissions" chart selection section while it is in beta, rather than in the "Overview" section?

Sure, I'll move it there.

Why are all the labels shown twice? Also, why is the red line shown twice in the 2050 emissions, why is it not shown for 1990?

This is a bug that was already solved in one of the commits. Are you sure your local branch is up-to-date with remote? I don't see the duplicate labels:

Ideally you would also see a column for 1990 emissions in the table view of the chart.

I agree. I'll ask the devs to see if this would be very easy to implement.

I would add the new GHG chart as the default for the direct emissions download

Good point! I'll do that.

[mabijkerk]

If you click on the dasboard items settings wheel and save again

I cannot see the wheel, so this does not work for me.

[mabijkerk]

This is a bug that was already solved in one of the commits. Are you sure your local branch is up-to-date with remote? I don't see the duplicate labels:

Yes I'm sure, maybe I'm on the wrong branches?

• etmodel: emissions-user-input-output
• etsource: emissions-user-input-output
• etengine: emissions-1990

[kndehaan]

The wheel becomes visible when you zoom out the page a lot. You're using the correct branches. I think strange things are happening here that might be related to caching as well? I think we should discuss it with the devs.