Skip to content

Conversation

@Darkheir
Copy link
Contributor

Description

Rely on TermSetQuery instead of a bool should query with many criteria on the same field as it should improve performances.

How was this PR tested?

Integration tests should still pass

@rdettai-sk
Copy link
Collaborator

Small clarification: we don't expect performances to be always improved, but we believe mapping the TermSet behavior here (warmup of the whole field) makes more sense. Performances will improve drastically when the list is long as the number of S3 queries generated by the warmup explodes. It might be a bit worst if there are only a couple terms in the list.

Ideally we could imagine an optimisation during the warmup to have something in between warming up individual terms and the whole field.

@rdettai-sk
Copy link
Collaborator

Test 0028-fast_only_field_query.yaml fails because TermSet queries seem to not be supported on fast fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants