Addressing issue #336

[jimportico]

Added code to address issue #336.

link: #336

[twiecki]

@jimportico Looks great, thanks for contributing this! Seems like our travis CI is broken, did you run the test suite to make things everything still passes?

[jimportico]

Hi @twiecki - I checked travis CI and see four failure messages that I'm having a difficulty reconciling.

Build Jobs:

• 630.1: The command "python setup.py install" failed and exited with 1 during .
• 630.2, 630.4, & 630.5: The command "conda create -q -n testenv --yes python=$TRAVIS_PYTHON_VERSION ipython flake8 numpy scipy nose matplotlib pandas=$PANDAS_VERSION statsmodels seaborn" failed and exited with 1 during .

I saw something similar on PR #346. That looked unrelated to the changes being submitted. Is that the case for mine as well?

[twiecki]

Yeah those are unrelated, just wanted to make sure they did pass with a functioning setup.

…

On Wed, Jan 15, 2020, 00:50 jimportico ***@***.***> wrote: Hi @twiecki <https://github.com/twiecki> - I checked travis CI and see four failure messages that I'm having a difficulty reconciling. Build Jobs: - 630.1: The command "python setup.py install" failed and exited with 1 during . - 630.2, 630.4, & 630.5: The command "conda create -q -n testenv --yes python=$TRAVIS_PYTHON_VERSION ipython flake8 numpy scipy nose matplotlib pandas=$PANDAS_VERSION statsmodels seaborn" failed and exited with 1 during . I saw something similar on PR #346 <#346>. That looked unrelated to the changes being submitted. Is that the case for mine as well? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#354?email_source=notifications&email_token=AAFETGH46ZWE7MCG5GK6G7TQ5ZFVVA5CNFSM4KFMJNHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI6RNSQ#issuecomment-574428874>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFETGBFG4GIW76MRHIJJMTQ5ZFVVANCNFSM4KFMJNHA> .

[twiecki]

Thanks @jimportico!

[twiecki]

If you want, in a separate PR you could add a unittest to make sure the feature works as desired.

[jimportico]

Thanks @twiecki - happy to help! I haven't submitted a unittest for an OSS project before but would like to learn more. Do you have a sample you can point me toward?