[CORRUPTED] Synthetic Benchmark PR #27546 - [bench] prefix@0412ca76 improvement(client): fix exactOptionalPropertyTypes for telemetry-utils - #12
Open
amirzaushnizer wants to merge 2 commits into
Conversation
…tils
`ChildLogger` (which is almost always the logger anything accesses) supports `minLogLevel` with a getter that may return `undefined`.
Update `ITelemetryBaseLogger` to allow `minLogLevel` to be `undefined`.
This is a type breaking change for anyone not using `exactOptionalPropertyTypes:false`, but not a runtime breaking change.
`telemetry-utils` corrections:
- use `...(cond ? {} { prop: value })` to only define properties with defined values.
- delete optional properties instead of setting to `undefined`.
- in logger helper functions allow explicit `undefined`
- internal `ChildLogger.create` clarified to expect to arguments though `undefined` is allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR microsoft#27546
Type: Corrupted (contains bugs)
Original PR Title: [bench] prefix@0412ca76 improvement(client): fix
exactOptionalPropertyTypesfor telemetry-utilsOriginal PR Description: Pre-fix reconstruction of microsoft#27546 at parent of 0412ca7 (bug present).
Original PR URL: microsoft#27546