Skip to content

[pre-commit.ci] pre-commit autoupdate - #240

Merged
djhoese merged 2 commits into
mainfrom
pre-commit-ci-update-config
Oct 6, 2026
Merged

djhoese merged 2 commits into
mainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci

@pre-commit-ci pre-commit-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.16.3 → v0.16.10](astral-sh/ruff-pre-commit@v0.16.3...v0.16.10)
@pnuu

pnuu commented Oct 6, 2026

Copy link
Copy Markdown
Member

The window build fails because setuptools is missing. It is a requirement in pyproject.toml, so shouldn't it be installed automatically?

Traceback (most recent call last):
  File "C:\Users\runneradmin\miniconda3\envs\test-environment\Lib\site-packages\Cython\Distutils\build_ext.py", line 12, in <module>
    import distutils.command.build_ext as _build_ext_module
ModuleNotFoundError: No module named 'distutils'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\runneradmin\miniconda3\envs\test-environment\Lib\site-packages\Cython\Distutils\build_ext.py", line 16, in <module>
    import setuptools.command.build_ext as _build_ext_module
ModuleNotFoundError: No module named 'setuptools'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\a\trollimage\trollimage\setup.py", line 7, in <module>
    from Cython.Build import build_ext
  File "C:\Users\runneradmin\miniconda3\envs\test-environment\Lib\site-packages\Cython\Build\__init__.py", line 9, in __getattr__
    from .Distutils import build_ext
  File "C:\Users\runneradmin\miniconda3\envs\test-environment\Lib\site-packages\Cython\Build\Distutils.py", line 1, in <module>
    from Cython.Distutils.build_ext import build_ext
  File "C:\Users\runneradmin\miniconda3\envs\test-environment\Lib\site-packages\Cython\Distutils\__init__.py", line 1, in <module>
    from Cython.Distutils.build_ext import build_ext
  File "C:\Users\runneradmin\miniconda3\envs\test-environment\Lib\site-packages\Cython\Distutils\build_ext.py", line 18, in <module>
    raise ImportError("'distutils' cannot be imported. Please install setuptools.")
ImportError: 'distutils' cannot be imported. Please install setuptools.

@djhoese

djhoese commented Oct 6, 2026

Copy link
Copy Markdown
Member

Hm we were probably getting lucky. The pip install -e . is fine, it installs it as needed. But then we reinstall the Cython extensions in the current environment using python setup.py build_ext which doesn't use pyproject.toml at all. So yeah we'll need to install setuptools into the environment.yaml. I'll do that...

It is used by the `python setup.py build_ext` call which uses the current environment not a `pyproject.toml` sandbox environment.
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 91.681%. remained the same — pre-commit-ci-update-config into main

@djhoese
djhoese merged commit af74848 into main Oct 6, 2026
42 checks passed
@djhoese
djhoese deleted the pre-commit-ci-update-config branch October 6, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants