Fix int64 bounding box truncation in V2 geometry transforms#9545
Fix int64 bounding box truncation in V2 geometry transforms#9545Sainava wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9545
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @Sainava! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Resolves the documented
TODOs intorchvision/transforms/v2/functional/_geometry.pyregarding integer bounding box casting.The Issue
When users pass bounding boxes as
torch.int64, subsequent format conversions (e.g.,XYXYtoCXCYWH) perform division operations. Without casting to a floating-point type first, this causes unsafe integer division/truncation, severely degrading the bounding box coordinates.The Fix
if bounding_boxes.dtype == torch.int64: bounding_boxes = bounding_boxes.float()prior toconvert_bounding_box_formatinside bothperspective_bounding_boxesandelastic_bounding_boxes.float64precision.original_dtype = bounding_boxes.dtypeat the start of the functions to ensure the returned bounding boxes are correctly cast back to the user's original requested dtype, preventing silent type mutations.Testing
Verified mathematically via local test suite execution:
pytest test/test_transforms_v2.pySpecifically validated against
TestElasticandTestPerspectiveto ensure all format edge cases maintain correctness across theint64 -> float32 -> int64round trip.