Skip to content

Enable 5-bit support on MLX#20811

Merged
metascroy merged 1 commit into
mainfrom
q5-support
Jul 9, 2026
Merged

Enable 5-bit support on MLX#20811
metascroy merged 1 commit into
mainfrom
q5-support

Conversation

@metascroy

@metascroy metascroy commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@pytorch-bot

pytorch-bot Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20811

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 166 Pending

As of commit 9e8ef77 with merge base f4b01a8 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Gasoonjia
Gasoonjia approved these changes Jul 9, 2026
View reviewed changes
Comment thread backends/mlx/builder/op_helpers.py
bits = (qmax - qmin + 1).bit_length() - 1
if bits not in [2, 4, 6, 8]:
if bits not in [2, 4, 5, 6, 8]:
return None

@Gasoonjia Gasoonjia Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering what will be happend if return None? rasie error?

@metascroy metascroy merged commit 5f6d1aa into main Jul 9, 2026
214 of 219 checks passed
@metascroy metascroy deleted the q5-support branch July 9, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gasoonjia Gasoonjia Gasoonjia approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@metascroy @Gasoonjia