NXP backend: added and refactored tests for converting unsqueeze/squeeze to view_copy#20810
Open
novak-vaclav wants to merge 1 commit into
Open
Conversation
novak-vaclav
requested review from
MartinPavella,
irtrukhina,
jirioc and
roman-janik-nxp
novak-vaclav
added
the
module: nxp
novak-vaclav
added
the
release notes: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20810
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit 3a3b701 with merge base 910c45c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the NXP backend test coverage for the edge pass that converts unsqueeze/squeeze nodes into view_copy, moving the tests to the newer lower_run_compare + DetailedGraphVerifier harness and adding QAT variants.
Changes:
- Replaced the prior full-pipeline +
convert_run_compare/graph-op presence checks withlower_run_compareand delegation-count verification viaDetailedGraphVerifier. - Consolidated repeated test logic into a shared helper and expanded parameterization for
squeezecases. - Added dedicated QAT test cases for both
unsqueeze→view_copyandsqueeze→view_copy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+26
to
+48
| @staticmethod | ||
| def assert_converted_to_view(model, input_shape, mocker, request, use_qat=False): | ||
| graph_verifier = DetailedGraphVerifier( | ||
| mocker, | ||
| expected_delegated_ops={ViewCopy: 1, AddTensor: 1}, | ||
| expected_non_delegated_ops={}, | ||
| ) | ||
| dataset = RandomDatasetCreator(low=-1.0, high=1.0) | ||
|
|
||
| # Use quantized dataset and allow single bit error. | ||
| remove_quant_io_ops = True | ||
| comparator = AllCloseOutputComparator(atol=1) | ||
|
|
||
| lower_run_compare( | ||
| model, | ||
| input_shape, | ||
| graph_verifier, | ||
| request, | ||
| dataset, | ||
| comparator, | ||
| use_qat=use_qat, | ||
| remove_quant_io_ops=remove_quant_io_ops, | ||
| ) |
Comment on lines
+12
to
+15
| from executorch.backends.nxp.tests.nsys_testing import ( | ||
| AllCloseOutputComparator, | ||
| lower_run_compare, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added and refactored tests for converting
unsqueeze/squeezetoview_copy.Test plan
tests can be manually run using
pytest -c /dev/null backends/nxp/tests/cc @robert-kalmar @JakeStevens @digantdesai @rascani @MartinPavella