Make enable_ssd_writeback outer check in FeatureEvict#5924
Open
lizhe-ji wants to merge 1 commit into
Open
Conversation
Summary: Resolves reviewer comment in D107491725 to add explicit flag control for SSD eviction writeback instead of relying on writeback_callback_ presence. Nest `enable_ssd_writeback` as upper level `if` condition in `start_training_eviction_loop` and `start_inference_eviction_loop`, with inner check for `writeback_callback` and dirty state or non-empty batch. This makes SSD-related eviction behavior controlled by explicit config flag rather than callback truthiness. Differential Revision: D108950148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Resolves reviewer comment in D107491725 to add explicit flag control for SSD eviction writeback instead of relying on writeback_callback_ presence. Nest
enable_ssd_writebackas upper levelifcondition instart_training_eviction_loopandstart_inference_eviction_loop, with inner check forwriteback_callbackand dirty state or non-empty batch. This makes SSD-related eviction behavior controlled by explicit config flag rather than callback truthiness.Differential Revision: D108950148