Skip to content

[django-filter] Broaden OrderingFilter fields parameter #16246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightcityblade wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

[django-filter] Broaden OrderingFilter fields parameter #16246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14545de
[django-filter] Broaden OrderingFilter fields parameter
Aug 19, 2026
db6c395
[django-filter] Type normalize_fields precisely
Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions stubs/django-filter/django_filters/filters.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from collections import OrderedDict
from collections.abc import Callable, Iterable
from typing import Any

Expand Down Expand Up @@ -303,7 +304,7 @@ class OrderingFilter(BaseCSVFilter, ChoiceFilter):
field_name: str | None = None,
lookup_expr: str | None = None,
*,
fields: dict[str, str] | Iterable[str] | Iterable[tuple[str, str]] = ...,
fields: dict[str, str] | Iterable[str | tuple[str, str]] = ...,
field_labels: dict[str, StrOrPromise] = ...,
# Inherited from ChoiceFilter
null_value: Any = ..., # Null value can be any type (None, empty string, etc.)
Expand All @@ -317,7 +318,7 @@ class OrderingFilter(BaseCSVFilter, ChoiceFilter):
def get_ordering_value(self, param: str) -> str: ...
def filter(self, qs: QuerySet[Any], value: Any) -> QuerySet[Any]: ...
@classmethod
def normalize_fields(cls, fields: Any) -> list[str]: ...
def normalize_fields(cls, fields: dict[str, str] | Iterable[str | tuple[str, str]]) -> OrderedDict[str, str]: ...
def build_choices(self, fields: Any, labels: dict[str, StrOrPromise] | None) -> list[tuple[str, str]]: ...

class FilterMethod:
Expand Down