Skip to content

Conversation

@gmtestandreview
Copy link

No description provided.

Copilot AI review requested due to automatic review settings January 1, 2026 14:11
@gmtestandreview
Copy link
Author

aa

Copy link
Author

@gmtestandreview gmtestandreview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,l

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes markdown linting issues across multiple documentation files in the typeshed repository. The changes primarily address formatting inconsistencies to comply with markdownlint rules.

Key changes:

  • Standardized heading levels (top-level documents now use # for main headers instead of missing headers or ##)
  • Added blank lines before code blocks for proper markdown formatting
  • Converted list markers from - to * for consistency
  • Replaced HTML table with standard markdown subsections in CONTRIBUTING.md

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/REGRESSION.md Changed main header from ## to #, subsection from ### to ##, and updated emphasis from _won't_ to *won't*
tests/README.md Added # header to first line, added blank lines before code blocks throughout the document
README.md Wrapped URL in angle brackets and removed $ prompt from bash command
MAINTAINERS.md Converted first line to proper header with # prefix
CONTRIBUTING.md Removed exclamation mark from header, added "Code formatting" section, converted HTML table to markdown subsections, standardized list markers to *, removed extra blank line, added blank lines before code blocks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


```bash
$ python3 tests/check_typeshed_structure.py
python3 tests/check_typeshed_structure.py
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command prompt was removed from this code block, making it inconsistent with all other bash code blocks in this file which use the (.venv3)$ prefix (e.g., lines 27-30, 38, 58, 113, 149, 157, 164, 216). For consistency, this should either include the prompt like the others, or all prompts should be removed throughout the file.

Suggested change
python3 tests/check_typeshed_structure.py
(.venv3)$ python3 tests/check_typeshed_structure.py

Copilot uses AI. Check for mistakes.
@srittau
Copy link
Collaborator

srittau commented Jan 1, 2026

I don't think this is helpful. I'm general, we need a clear motivation for changing our documentation, which AI generated descriptions can't provide.

1 similar comment
@srittau
Copy link
Collaborator

srittau commented Jan 1, 2026

I don't think this is helpful. I'm general, we need a clear motivation for changing our documentation, which AI generated descriptions can't provide.

@srittau srittau closed this Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants