Skip to content

gh-143200: fix UAFs in Element.__{set,get}item__ when the element is concurrently mutated #143226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
picnixz merged 4 commits into from
Dec 29, 2025
Merged

gh-143200: fix UAFs in Element.__{set,get}item__ when the element is concurrently mutated #143226

picnixz merged 4 commits into from
Dec 29, 2025
+85 −31

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Dec 27, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 27, 2025
Closed
@picnixz picnixz added topic-XML needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 27, 2025
serhiy-storchaka
serhiy-storchaka reviewed Dec 27, 2025
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Dec 28, 2025
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Dec 29, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@picnixz picnixz merged commit b6b0e14 into python:main Dec 29, 2025
50 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 29, 2025

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@picnixz picnixz deleted the fix/xml/uaf-in-sub-143200 branch December 29, 2025 17:30
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 29, 2025
@picnixz @miss-islington
pythongh-143200: fix UAFs in Element.__{set,get}item__ when the ele…
f3bc3a7 
…ment is concurrently mutated (pythonGH-143226)

(cherry picked from commit b6b0e14)

Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 29, 2025
@picnixz @miss-islington
pythongh-143200: fix UAFs in Element.__{set,get}item__ when the ele…
e02ebbd 
…ment is concurrently mutated (pythonGH-143226)

(cherry picked from commit b6b0e14)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 29, 2025

GH-143273 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 29, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 29, 2025

GH-143274 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 29, 2025
picnixz added a commit that referenced this pull request Dec 29, 2025
@miss-islington @picnixz
[3.14] gh-143200: fix UAFs in Element.__{set,get}item__ when the el…
7ff87fa 
…ement is concurrently mutated (GH-143226) (#143273)

gh-143200: fix UAFs in `Element.__{set,get}item__` when the element is concurrently mutated (GH-143226)
(cherry picked from commit b6b0e14)

Co-authored-by: Bénédikt Tran <[email protected]>
picnixz added a commit that referenced this pull request Dec 29, 2025
@miss-islington @picnixz
[3.13] gh-143200: fix UAFs in Element.__{set,get}item__ when the el…
93cb42f 
…ement is concurrently mutated (GH-143226) (#143274)

gh-143200: fix UAFs in `Element.__{set,get}item__` when the element is concurrently mutated (GH-143226)
(cherry picked from commit b6b0e14)

Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

topic-XML

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @serhiy-storchaka