-
Notifications
You must be signed in to change notification settings - Fork 39
docs: add quick start guide and glossary from learning-fromager repo #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@shifa-khan I am adding the glossary in a separate PR #884 |
| The ``-c`` option ensures fromager uses exactly the versions you specify. | ||
|
|
||
| Next Steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Once you remove glossary, we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made changes as requested.
2db6e21 to
0ddf740
Compare
| :maxdepth: 2 | ||
|
|
||
| using.md | ||
| quickstart.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep quickstart.rst before using.md for users scanning the documentation. A "Quick Start" is typically the first thing new users look for.
Add quickstart.rst with installation instructions and a simple stevedore example for new users. Update getting-started.rst to point new users to the quick start guide. Content adapted from the learning-fromager repository. Signed-off-by: shifa-khan [email protected] Closes: python-wheel-build#799
|
Looks good to me. @dhellmann You might want to take a look as well. Will wait for your review for a day (for lazy consensus) else going to merge this. |
dhellmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition, thank you!
bfdda7e
into
python-wheel-build:main
Add quickstart.rst with installation instructions and a simple stevedore example for new users. Add glossary.md with terminology definitions. Update getting-started.rst to point new users to the quick start guide.
Content adapted from the learning-fromager repository.
Signed-off-by: shifa-khan [email protected]
Closes: #799