Repository navigation
Don't overwrite Control's args when checking position - #2336
Open
NotAFlightRisk wants to merge 1 commit into
Open
NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
The position check assigned get_args(TypePosition) to args, which is also the name of the *args parameter, so self.args became the four corner names. Leaflet then read the first corner name as the options object and ignored position and every other option.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you pass
positiontoControlit's ignored, and so is every other option.Control("Zoom", position="bottomright")rendersnew L.Control.Zoom("bottomright", "bottomleft", "topright", "topleft", {"position": "bottomright"}), Leaflet takes the first string as its options, and the buttons stay top-left. Any real positional args (a MiniMap's layer, say) get lost too.The walrus in the position check assigns to
args, which is also the*argsparameter, so renaming it is all it needed. The new test passes a real position, since the existing one only tries a bad one. I checked it before and after in Chromium against 0.20.0.