Skip to content

Add docstrings for ParkingLot.broken_by and HasFileno.fileno#3470

Closed
krrishapatel wants to merge 4 commits into
python-trio:mainfrom
krrishapatel:docs/add-parkinglot-broken-by-docstring
Closed

Add docstrings for ParkingLot.broken_by and HasFileno.fileno#3470
krrishapatel wants to merge 4 commits into
python-trio:mainfrom
krrishapatel:docs/add-parkinglot-broken-by-docstring

Conversation

@krrishapatel

@krrishapatel krrishapatel commented Jul 12, 2026

Copy link
Copy Markdown

No description provided.

Addresses the remaining unchecked items from #3221:
- ParkingLot.broken_by: documents the list of tasks that broke the lot
- HasFileno.fileno: documents the protocol method
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (5a5111b) to head (5fa7df9).

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3470   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             128          128           
  Lines           19423        19424    +1     
  Branches         1317         1317           
===============================================
+ Hits            19423        19424    +1     
Files with missing lines Coverage Δ
src/trio/_core/_parking_lot.py 100.00000% <100.00000%> (ø)
src/trio/_subprocess.py 100.00000% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A5rocks

A5rocks commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

CI is failing?

@A5rocks A5rocks added the skip newsfragment Newsfragment is not required label Jul 12, 2026
@jakkdl

jakkdl commented Jul 14, 2026

Copy link
Copy Markdown
Member

the RTD failure is very much not unrelated:
looking for now-outdated files... WARNING: outdated list of undocumented things in docs/source/conf.py: 'trio._subprocess.HasFileno.fileno' has a docstring

@A5rocks

A5rocks commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Tbh I'm tempted to close this cause all the comments have been LLM-generated. Please don't do that here anymore...

@krrishapatel krrishapatel deleted the docs/add-parkinglot-broken-by-docstring branch July 15, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newsfragment Newsfragment is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants