Recognize dates inside reversed intervals - #1022
Open
charan-rathore wants to merge 1 commit into
Open
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reversed interval can be iterated from its start to its end, but its membership check always returns False. For example, January 3 is yielded by an interval from January 4 to January 2 but is reported absent by the same interval.
Compare against the reversed bounds when start exceeds end. Preserve inclusive endpoints and forward interval behavior. Add twenty regression cases covering Date and DateTime values, both directions, endpoints, and values outside the bounds.
This is a self-discovered bug. No issue or prior maintainer discussion is claimed.
Validation on Python 3.12.12:
The Rust extension variant, Rust lint, documentation build, other Python versions and operating systems were not tested. This changes Python interval membership only.
Pull Request Check List