Repository navigation
Github action for making a new release #5
Description
Add a Github action that automates the release process as much as possible. Use mypy-ls's release action for inspiration.
Update RELEASE.md accordingly.
Add a Github action that automates the release process as much as possible. Use mypy-ls's release action for inspiration.
Update RELEASE.md accordingly.
Activity
haplo commentedon Apr 12, 2022
Should use a dedicated PyPI API token for the upload: https://pyfound.blogspot.com/2020/01/start-using-2fa-and-api-tokens-on-pypi.html
twine seems to not support API tokens yet, but there is a workaround.
peterrus commentedon May 1, 2022
Hey @haplo, I might be interested in setting this up. How do we go about the token? I can imagine you not wanting to share that with a random stranger on the internet right now.
Have you given this any thought?
Maybe something like this: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
haplo commentedon May 1, 2022
Hi @peterrus, thank you for taking an interest on this task.
It looks like Github Actions has secrets support, so that's what we should be using. I would create a PyPI API token limited only to this package, then add a
PYPI_TOKENsecret (so it would beSECRET_PYPI_TOKENwhen referenced from the Github Action) in the Github repository settings.I'm adding the secret now, let me know if you hit any issues with the action.
haplo commentedon May 1, 2022
@ccordoba12 I think I might be lacking permissions to admin this repository. Would you review my access, or set up the PyPI token secret as described in my previous message?
peterrus commentedon May 1, 2022
Ok, I will monitor this and see if I can find some time soon to have a look at this!
haplo commentedon May 18, 2022
Ping @ccordoba12, please see my above message. 🙏
ccordoba12 commentedon Sep 30, 2022
Hey @haplo, sorry for the delay in seeing your message. I just granted you admin permissions to this repo.