Skip to content

Fix KeyError that occurred when formatting compact currencies of exactly one thousand in several locales #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bartbroere wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix KeyError that occurred when formatting compact currencies of exactly one thousand in several locales #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64465cc
Add a smoke test for thousands and compact currency formats
bartbroere Jan 15, 2026
7034ca1
Fall back to other when formatting compact currencies
bartbroere Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions babel/numbers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,8 @@ def _get_compact_format(
plural_form = "other"
if number == 1 and "1" in compact_format:
plural_form = "1"
if str(magnitude) not in compact_format[plural_form]:
plural_form = "other" # fall back to other as the implicit default
format = compact_format[plural_form][str(magnitude)]
number = rounded
break
Expand Down
3 changes: 3 additions & 0 deletions tests/test_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
1.2 - 1.0, # Inaccurate float
10, # Plain old integer
0, # Zero
1000, # A thousand (previously raised KeyError in the nl locale for compact currencies)
)


Expand Down Expand Up @@ -46,6 +47,8 @@ def test_smoke_numbers(locale):
assert numbers.format_decimal(number, locale=locale, numbering_system="default")
assert numbers.format_currency(number, "EUR", locale=locale)
assert numbers.format_currency(number, "EUR", locale=locale, numbering_system="default")
assert numbers.format_compact_currency(number, "EUR", locale=locale)
assert numbers.format_compact_currency(number, "EUR", locale=locale, numbering_system="default")
assert numbers.format_scientific(number, locale=locale)
assert numbers.format_scientific(number, locale=locale, numbering_system="default")
assert numbers.format_percent(number / 100, locale=locale)
Expand Down
Loading