Fix only_rerun marker precedence test - #348
Merged
Merged
Conversation
Contributor
Author
|
This is a test-only one-line fix, so I left out a changelog entry in line with the “unless the change is trivial” guidance in |
icemac
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_only_rerun_flag_in_flaky_markerbuilds CLI arguments but doesn't pass them torunpytest(). This means its marker-vs-CLI cases never exercise the CLI option.Pass the arguments to
runpytest()so the test verifies that marker-levelonly_reruntakes precedence over the CLI value.To confirm the gap, I temporarily reversed the precedence. The original test still passed, while the corrected test failed as expected.