Skip to content

Replace deprecated Config.getvalue() with Config.getoption() #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icemac merged 1 commit into from
Aug 17, 2026
+8 −8
Merged

Replace deprecated Config.getvalue() with Config.getoption() #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/345.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Replace deprecated ``Config.getvalue()`` calls with ``Config.getoption()``.
15 changes: 7 additions & 8 deletions src/pytest_rerunfailures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def pytest_addoption(parser):


def _get_global_reruns(config):
reruns = config.getvalue("reruns")
reruns = config.getoption("reruns")
if reruns is not None:
return reruns

Expand All @@ -191,14 +191,13 @@ def _get_global_reruns(config):
# making sure the options make sense
# should run before / at the beginning of pytest_cmdline_main
def check_options(config):
val = config.getvalue
if (
config.option.max_suite_reruns is not None
and config.option.max_suite_reruns < 0
):
raise pytest.UsageError("--max-suite-reruns must be >= 0")
reruns = config.getvalue("force_reruns") or _get_global_reruns(config)
if not val("collectonly") and reruns:
reruns = config.getoption("force_reruns") or _get_global_reruns(config)
if not config.getoption("collectonly") and reruns:
if config.option.usepdb: # a core option
raise pytest.UsageError("--reruns incompatible with --pdb")

Expand All @@ -208,7 +207,7 @@ def _get_marker(item):


def get_reruns_count(item):
reruns = item.session.config.getvalue("force_reruns")
reruns = item.session.config.getoption("force_reruns")
if reruns is not None:
return reruns

Expand All @@ -224,7 +223,7 @@ def get_reruns_count(item):
else:
marker_reruns = 1

if item.session.config.getvalue("reruns_mode") == "append":
if item.session.config.getoption("reruns_mode") == "append":
global_reruns = _get_global_reruns(item.session.config)
if global_reruns is not None:
return marker_reruns + global_reruns
Expand All @@ -245,7 +244,7 @@ def get_reruns_delay(item):
else:
delay = 0
else:
delay = item.session.config.getvalue("reruns_delay")
delay = item.session.config.getoption("reruns_delay")
if delay is None:
try:
delay = float(item.session.config.getini("reruns_delay"))
Expand Down Expand Up @@ -273,7 +272,7 @@ def get_reruns_delay_backoff_factor(item):
else:
factor = 1.0
else:
factor = item.session.config.getvalue("reruns_delay_backoff_factor")
factor = item.session.config.getoption("reruns_delay_backoff_factor")
if factor is None:
try:
factor = float(
Expand Down
Loading