Add RFC 9110 status code constants - #1069
Open
mbeijen wants to merge 1 commit into
Open
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/httpx2/httpx2/_status_codes.py">
<violation number="1" location="src/httpx2/httpx2/_status_codes.py:160">
P3: The alias definitions preserve the original UPPERCASE constant names, but `codes.request_entity_too_large` etc. (the lowercase `requests`-compatible forms) are silently dropped because the `for code in codes:` loop only iterates over canonical members, not aliases. Anyone migrating from `httpx.codes.request_entity_too_large` will get an `AttributeError`. Consider preserving these too, either via explicit `setattr` calls after the loop or by adding them as additional alias entries.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| NETWORK_AUTHENTICATION_REQUIRED = 511, "Network Authentication Required" | ||
|
|
||
| # for backwards compatibility, keep the old constants around | ||
| REQUEST_ENTITY_TOO_LARGE = CONTENT_TOO_LARGE |
Contributor
There was a problem hiding this comment.
P3: The alias definitions preserve the original UPPERCASE constant names, but codes.request_entity_too_large etc. (the lowercase requests-compatible forms) are silently dropped because the for code in codes: loop only iterates over canonical members, not aliases. Anyone migrating from httpx.codes.request_entity_too_large will get an AttributeError. Consider preserving these too, either via explicit setattr calls after the loop or by adding them as additional alias entries.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/httpx2/httpx2/_status_codes.py, line 160:
<comment>The alias definitions preserve the original UPPERCASE constant names, but `codes.request_entity_too_large` etc. (the lowercase `requests`-compatible forms) are silently dropped because the `for code in codes:` loop only iterates over canonical members, not aliases. Anyone migrating from `httpx.codes.request_entity_too_large` will get an `AttributeError`. Consider preserving these too, either via explicit `setattr` calls after the loop or by adding them as additional alias entries.</comment>
<file context>
@@ -156,6 +156,12 @@ def is_error(cls, value: int) -> bool:
NETWORK_AUTHENTICATION_REQUIRED = 511, "Network Authentication Required"
+ # for backwards compatibility, keep the old constants around
+ REQUEST_ENTITY_TOO_LARGE = CONTENT_TOO_LARGE
+ REQUEST_URI_TOO_LONG = URI_TOO_LONG
+ REQUESTED_RANGE_NOT_SATISFIABLE = RANGE_NOT_SATISFIABLE
</file context>
mbeijen
force-pushed
the
rfc9110-status-texts
branch
from
July 15, 2026 20:53
197af58 to
b1cc86e
Compare
mbeijen
added a commit
to mbeijen/httpx2
that referenced
this pull request
Jul 15, 2026
Kludex
reviewed
Jul 28, 2026
Comment on lines
+159
to
+163
| # for backwards compatibility, keep the old constants around | ||
| REQUEST_ENTITY_TOO_LARGE = CONTENT_TOO_LARGE | ||
| REQUEST_URI_TOO_LONG = URI_TOO_LONG | ||
| REQUESTED_RANGE_NOT_SATISFIABLE = RANGE_NOT_SATISFIABLE | ||
| UNPROCESSABLE_ENTITY = UNPROCESSABLE_CONTENT |
Member
There was a problem hiding this comment.
We need to use __getattr__ and deprecate the old ones.
Kludex
reviewed
Jul 28, 2026
Comment on lines
+13
to
+14
| * RFC 9110: HTTP Semantics | ||
| obsoletes 7231, which obsoletes 2616. Obsoletes 7238 |
Member
There was a problem hiding this comment.
Suggested change
| * RFC 9110: HTTP Semantics | |
| obsoletes 7231, which obsoletes 2616. Obsoletes 7238 | |
| * RFC 9110: HTTP Semantics, obsoletes 7231 & 7238 |
Kludex
reviewed
Jul 28, 2026
Comment on lines
+28
to
+42
|
|
||
|
|
||
| def test_rfc9110_status_texts() -> None: | ||
| assert httpx2.codes.get_reason_phrase(413) == "Content Too Large" | ||
| assert httpx2.codes.get_reason_phrase(414) == "URI Too Long" | ||
| assert httpx2.codes.get_reason_phrase(416) == "Range Not Satisfiable" | ||
| assert httpx2.codes.get_reason_phrase(422) == "Unprocessable Content" | ||
|
|
||
|
|
||
| def test_pre_rfc9110_aliases_still_work() -> None: | ||
| # kept for backwards compatibility with the pre-RFC 9110 constant names | ||
| assert httpx2.codes.REQUEST_ENTITY_TOO_LARGE == httpx2.codes.CONTENT_TOO_LARGE # type: ignore[comparison-overlap] | ||
| assert httpx2.codes.REQUEST_URI_TOO_LONG == httpx2.codes.URI_TOO_LONG | ||
| assert httpx2.codes.REQUESTED_RANGE_NOT_SATISFIABLE == httpx2.codes.RANGE_NOT_SATISFIABLE | ||
| assert httpx2.codes.UNPROCESSABLE_ENTITY == httpx2.codes.UNPROCESSABLE_CONTENT |
mbeijen
force-pushed
the
rfc9110-status-texts
branch
3 times, most recently
from
July 28, 2026 08:38
68e7f79 to
8d830b2
Compare
RFC 9110 (HTTP Semantics) renamed several status phrases and obsoletes RFC 7231/7238. Add the new constant names and phrases, deprecating the old constant names as aliases for backwards compatibility: - REQUEST_ENTITY_TOO_LARGE -> CONTENT_TOO_LARGE (413) - REQUEST_URI_TOO_LONG -> URI_TOO_LONG (414) - REQUESTED_RANGE_NOT_SATISFIABLE -> RANGE_NOT_SATISFIABLE (416) - UNPROCESSABLE_ENTITY -> UNPROCESSABLE_CONTENT (422)
mbeijen
force-pushed
the
rfc9110-status-texts
branch
from
July 28, 2026 08:38
8d830b2 to
16c1de0
Compare
Kludex
reviewed
Jul 28, 2026
| stacklevel=2, | ||
| ) | ||
| return cls[new_name] | ||
| raise AttributeError(name) |
Member
There was a problem hiding this comment.
Does this exception matches the message you'd receive before adding this metadata?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9110 (HTTP Semantics) obsoletes RFC 7231 (which obsoletes 2616) and RFC 7238, and renamed several status phrases. This adds the new constant names and phrases, keeping the old constant names as aliases for backwards compatibility:
REQUEST_ENTITY_TOO_LARGE→CONTENT_TOO_LARGE(413)REQUEST_URI_TOO_LONG→URI_TOO_LONG(414)REQUESTED_RANGE_NOT_SATISFIABLE→RANGE_NOT_SATISFIABLE(416)UNPROCESSABLE_ENTITY→UNPROCESSABLE_CONTENT(422)Ported from a fix I originally carried in the httpxyz fork.