Verification fixes - #572
Open
pulkkins wants to merge 7 commits into
Open
Conversation
dnerini
requested changes
Aug 18, 2026
dnerini
left a comment
dnerini
left a comment
Member
There was a problem hiding this comment.
Hi Seppo, thanks a lot for the nice contribution. I found only one issue that is causing the tests to fail.
|
|
||
| def rapsd( | ||
| field, fft_method=None, return_freq=False, d=1.0, normalize=False, **fft_kwargs | ||
| field, fft_method=np.fft, return_freq=False, d=1.0, normalize=False, **fft_kwargs |
Member
There was a problem hiding this comment.
looks like change this broke some logic elsewhere, see failing tests.
e.g. now fftgenerators.py#L150 should include fft_method=None, if I'm not wrong?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch introduces fixes to the documentation of the verification and utils modules:
fft_method=np.fftby default to avoid confusion of the input type. Withfft_method=Nonethe method previously assumed that the input is already Fourier-transformed, which is not the most common use case.