Fix external nowcast only zeros - #566
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 84.64% 84.64%
=======================================
Files 170 170
Lines 15095 15095
=======================================
Hits 12777 12777
Misses 2318 2318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RubenImhoff
approved these changes
Aug 6, 2026
RubenImhoff
left a comment
RubenImhoff
left a comment
Contributor
There was a problem hiding this comment.
Nice work, looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought I fixed this in #546, but I realized now that an external nowcast does not necessarily have to have nan's at the edge (especially in our usecase where we run the external nowcast on a larger domain to explicitly prevent this).
This should not be an issue if it were not for the bug where, if there are no nan's anywhere in the domain, the code that is supposed to fill this part with values from nwp will simply set the entire domain to 0.
The simple fix is to not try to fill in the nan's when there are no nan's anywhere in the domain.