Add test for vf_ground_sky_2d view factor bounds #2690
Closed
+27
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bifacial.utils.vf_ground_sky_2dinterpretsmax_rowsasymmetrically #1867docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Description
Fixes an off-by-one / fencepost issue in
vf_ground_sky_2dwhere one fewer skywedge was considered on the right side compared to the left side in symmetric
geometries.
The fix includes horizon bounds (cos(0)=1 and cos(pi)=-1) so the wedge
calculation is consistent on both sides.
Tests
Added a regression test
test_vf_ground_sky_2d_returns_valid_rangeto ensurethe returned view factor stays within the physically valid range [0, 1].