Create nighttime_offset_correction function#173
Draft
AdamRJensen wants to merge 5 commits intopvlib:mainfrom
Draft
Create nighttime_offset_correction function#173AdamRJensen wants to merge 5 commits intopvlib:mainfrom
AdamRJensen wants to merge 5 commits intopvlib:mainfrom
Conversation
Member
Author
|
The current implementation manually corrects midnight to be included in the day before/after corresponding to whether the data is right or left labeled, and then passes the adjusted time series to However, this could automatically be handled by the If reviewers agree, I prefer the latter implementation as it's a lot cleaner and easier to read. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/api.rst.in
docs/whatsnewfor all changes. Includes link to the GitHub Issue with
:issue:`num`or this Pull Request with
:pull:`num`. Includes contributor nameand/or GitHub username (link with
:ghuser:`user`).This PR proposes one method for calculating the nighttime offsets discussed in #170. It is by no means a suggestion for this specific implementation to be the way forward, but making a PR simple makes it more efficient to discuss this particular implementation.