Fix metadata.rb syntax error and add missing test coverage - #1458
Closed
bronachfalls wants to merge 3 commits into
Closed
Fix metadata.rb syntax error and add missing test coverage#1458bronachfalls wants to merge 3 commits into
bronachfalls wants to merge 3 commits into
Conversation
- Fix syntax error introduced in #1453: `include?` called without parentheses caused a SyntaxError, silently breaking all tests that depend on PDK::Module::Metadata (release, update, convert, cli/release) - Update stale regex in metadata_spec to match the updated error message that now includes "openvox" alongside "puppet" - Add spec files for previously untested classes: PDK::Generate::Fact, PDK::Generate::Function, PDK::Config::Validator Overall line coverage: 81.73% → 91.35% Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace string concatenation with interpolation in fact_spec and function_spec to satisfy the Style/StringConcatenation cop. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…json' - Extract ['puppet', 'openvox'] to PUPPET_REQUIREMENT_NAMES constant to satisfy Performance/CollectionLiteralInLoop cop - Add missing `require 'json'` to metadata_spec.rb, exposed by the SyntaxError fix (from_file tests use .to_json without requiring json) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include?called without parentheses caused a SyntaxError, silently breaking all tests that depend on PDK::Module::Metadata (release, update, convert, cli/release)Overall line coverage: 81.73% → 91.35%
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist