Repository navigation
Remove remanents of SFTP support - #8248
Conversation
|
Thought we were just removing the docs saying we support it, no functional changes? |
Well it was already effectively disabled so removing it entirely doesn't really have a functional change? My understanding is that we were ripping it out entirely. The docs already called it broken |
| # class TestDomainGoogleSettingsSerializer(DomainSettingsBaseMixin, TestCase): | ||
| # storage_class = "storages.backends.gcloud.GoogleCloudStorage" | ||
| # serializer_class = GoogleSettingsSerializer | ||
| # required_settings = {"bucket_name": "test", "project_id": "testtest"} |
There was a problem hiding this comment.
Don't remove the google test.
|
I thought removing it too. How else will we hear from the people that didn't read in the docs for 3 years how broken their installation is? |
|
|
||
| BACKEND_CHOICES = ( | ||
| ("pulpcore.app.models.storage.FileSystem", "Use local filesystem as storage"), | ||
| # ("pulpcore.app.models.storage.PulpSFTPStorage", "Use SFTP server as storage"), |
There was a problem hiding this comment.
I think this line means it was fundamentally impossible to have used previously?
There was a problem hiding this comment.
Ehh, only for non-default domains it was impossible to use. You could still configure it for the default/non-domain systems.
There was a problem hiding this comment.
Eh, yeah, you're probably correct about that.
In that case we should at least have a changelog
It has been buggy and effectively disabled for a long time. Get rid of it completely.
It has been buggy and effectively disabled for a long time. Get rid of it completely.
https://redhat.atlassian.net/browse/PULP-2555