fix: stop mutating auth.User help_text to silence phantom migration warning - #1412
Merged
Conversation
…arning admin.py set help_text on Django's built-in User.username field at import time. Django tracks help_text in migrations, so every deploy warned that the auth app was out of sync but auth is Django-owned, so it could never be fixed. Dropped the line. The help text is already set on the admin form, so nothing changes for users. Kept the nearby validators override, it doesn't affect migrations. Verified in the dev container: migrate now runs clean. JIRA: PULP-2263 Signed-off-by: Bryan ramos <bramos@redhat.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideStops mutating Django’s built‑in auth.User.username help_text at import time to eliminate spurious migration warnings, while retaining the custom username validator override and documenting the migration-tracking behavior in comments. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
dkliban
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
admin.py set help_text on Django's built-in User.username field at import time. Django tracks help_text in migrations, so every deploy warned that the auth app was out of sync but auth is Django-owned, so it could never be fixed.
Dropped the line. The help text is already set on the admin form, so nothing changes for users. Kept the nearby validators override, it doesn't affect migrations.
Verified in the dev container: migrate now runs clean.
JIRA: PULP-2263
Summary by Sourcery
Bug Fixes: