Skip to content

Upgrade pulpcore to 3.116.0 - #1398

Merged
dkliban merged 1 commit into
pulp:mainfrom
dkliban:upgrade-pulpcore-3.116.0
Aug 13, 2026
Merged

Upgrade pulpcore to 3.116.0#1398
dkliban merged 1 commit into
pulp:mainfrom
dkliban:upgrade-pulpcore-3.116.0

Conversation

@dkliban

@dkliban dkliban commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Upgrade pulpcore from 3.115.2 to 3.116.0
  • Remove patch 0061-Release-locks-on-fetch_task-exception.patch — upstreamed in pulpcore 3.116.0 via pulp/pulpcore#7945, which is a comprehensive fix covering all six Redis lock leak paths

Notable 3.116.0 changes

  • Fixed RedisWorker leaking Redis locks when task acquire, abort, cancel, or immediate dispatch cleanup failed
  • Reduced lock contention for distribution updates that leave base_path unchanged
  • Fixed temp file leak in pull-through metadata streaming
  • Fixed domain list exposing all domains to authenticated users
  • Increased content app max HTTP header size to 16384 bytes for PQC certificate support

Test plan

  • Verify container image builds successfully (patch 0061 no longer applied)
  • Verify task processing works correctly with the new pulpcore lock handling
  • Run functional test suite

Fixes: PULP-2244

🤖 Generated with Claude Code

Summary by Sourcery

Upgrade pulpcore dependency to 3.116.0 and remove a now-upstreamed custom patch from the container build.

Enhancements:

  • Update pulp_service requirements to use pulpcore 3.116.0 instead of 3.115.2.
  • Simplify Docker image build by dropping the release-locks-on-fetch_task-exception patch that is included upstream in pulpcore 3.116.0.

Remove patch 0061 (Release-locks-on-fetch_task-exception) which was
upstreamed via pulp/pulpcore#7945 with a comprehensive fix covering
all six Redis lock leak paths.

Fixes: PULP-2244

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Upgrade pulpcore to 3.116.0 and drop a now-upstreamed local patch that fixed Redis lock leaks, ensuring the Docker build and service dependencies use the new core version without applying the redundant patch.

File-Level Changes

Change Details Files
Bump pulpcore dependency to 3.116.0 and align the service with upstream fixes (including Redis lock leak handling).
  • Updated pulpcore pinned version in requirements to 3.116.0.
  • Kept other pulp-related dependency versions unchanged to minimize blast radius.
pulp_service/requirements.txt
Stop applying the custom Redis lock leak patch in the container image because its fix is now included upstream.
  • Removed COPY and RUN steps that applied 0061-Release-locks-on-fetch_task-exception.patch during image build.
  • Deleted the 0061-Release-locks-on-fetch_task-exception.patch asset from the repository.
Dockerfile
images/assets/patches/0061-Release-locks-on-fetch_task-exception.patch

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dkliban
dkliban merged commit 1b1f19e into pulp:main Aug 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant