Skip to content

refactor: use protokit native module configuration#67

Open
stanlou wants to merge 1 commit intodevelopfrom
refactor--protokit-native-modules-configuration
Open

refactor: use protokit native module configuration#67
stanlou wants to merge 1 commit intodevelopfrom
refactor--protokit-native-modules-configuration

Conversation

@stanlou
Copy link
Collaborator

@stanlou stanlou commented Mar 25, 2026

closes #61

@stanlou stanlou requested a review from rpanic March 25, 2026 11:33
redis: {
host: process.env.REDIS_HOST ?? "redis",
port: Number(process.env.REDIS_PORT ?? 6379),
password: process.env.REDIS_PASSWORD ?? "password",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is where we will run into issues - we need to choose a different db number for this, otherwise it will conflict with the tree db if it's in the same database

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's correct in development btw :)

settlementEnabled,
}),
...DefaultModules.localWorker(),
WorkerModule: WorkerModule.from(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how little configuration this is

...protocol.settlementModules,
}),
Sequencer: Sequencer.from({
// ordering of the modules matters due to dependency resolution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics missing here

...DefaultModules.core({ settlementEnabled }),
...DefaultModules.redisTaskQueue(),
...DefaultModules.sequencerIndexer(),
//OpenTelemetryServer,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No metrics here imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Impl: Starter kit modules attempt 2

2 participants