Skip to content

Drop deprecated fields + use yaml.UnmarshalStrict()#673

Merged
pedro-stanaka merged 3 commits into
prometheus:masterfrom
simonhammes:strict-config-parsing-drop-deprecated-fields
Jun 30, 2026
Merged

Drop deprecated fields + use yaml.UnmarshalStrict()#673
pedro-stanaka merged 3 commits into
prometheus:masterfrom
simonhammes:strict-config-parsing-drop-deprecated-fields

Conversation

@simonhammes

@simonhammes simonhammes commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

This enables strict config parsing and removes all deprecated config fields (as suggested in #608 (comment)).

I also removed all test cases that turned out to be redundant.

Fixes #546

@pedro-stanaka pedro-stanaka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase against master

@simonhammes
simonhammes force-pushed the strict-config-parsing-drop-deprecated-fields branch from fca97a3 to 0245c73 Compare June 29, 2026 18:58
I also removed all test cases that turned out to be redundant

Signed-off-by: simonhammes <simonhammes@users.noreply.github.com>
Fixes #546

Supersedes #608

Signed-off-by: simonhammes <simonhammes@users.noreply.github.com>
This was introduced in #709

Signed-off-by: simonhammes <simonhammes@users.noreply.github.com>
@simonhammes
simonhammes force-pushed the strict-config-parsing-drop-deprecated-fields branch from 5638231 to 54462fb Compare June 29, 2026 19:05
@simonhammes

Copy link
Copy Markdown
Contributor Author

please rebase against master

Done, thanks for the review!

@pedro-stanaka
pedro-stanaka merged commit 06c2edd into prometheus:master Jun 30, 2026
9 checks passed
@simonhammes
simonhammes deleted the strict-config-parsing-drop-deprecated-fields branch July 1, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject configuration with unknown fields

2 participants